[jira] [Commented] (OFBIZ-10348) Refactoring Variable Scope for org.apache.ofbiz.entity

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464757#comment-16464757 ]

Taher Alkhateeb commented on OFBIZ-10348:
-----------------------------------------

Too large, and pattern-driven instead of refactoring-driven as stated in other related JIRAs. I highly recommend breaking it down with more proper and slow study of the code. These kinds of commits can have massive repercussions on the code. There is a lot of runtime stuff happening in OFBiz that such sweeping changes might be very dangerous.

> Refactoring Variable Scope for org.apache.ofbiz.entity
> ------------------------------------------------------
>
>                 Key: OFBIZ-10348
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10348
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pradhan Yash Sharma
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10348_1.patch, OFBIZ-10348_2.patch
>
>

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)