[jira] [Commented] (OFBIZ-10352) Refactoring Variable Scope for org.apache.ofbiz.minilang

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624588#comment-16624588 ]

Girish Vasmatkar commented on OFBIZ-10352:
------------------------------------------

Even though patch size is large, it will not be difficult to apply it post review -
 * Since module reference in most classes is a constant, made it ALL CAPS.
 * Also reduced scope of variables to private as there is just no need for them to be available outside of the class.

> Refactoring Variable Scope for org.apache.ofbiz.minilang
> --------------------------------------------------------
>
>                 Key: OFBIZ-10352
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10352
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pradhan Yash Sharma
>            Assignee: Girish Vasmatkar
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10352.patch
>
>

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)