[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473008#comment-16473008 ]

Deepak Dixit commented on OFBIZ-10398:
--------------------------------------

Nah, I am suggesting that we can improve code in same ticket. As we are doing effort to rename and update service occurrences, so why not update it properly :)

> Rename deletePartyContactMechPurpose* services
> ----------------------------------------------
>
>                 Key: OFBIZ-10398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10398
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, party
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>         Attachments: OFBIZ-10398-rename.patch
>
>
> Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose are misnomers, as these functions don't delete records but expires those by setting the thruDate. The misnomers creates unnecessary confusion.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)