[jira] [Commented] (OFBIZ-10410) Refactor `JavaEventHandler` class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10410) Refactor `JavaEventHandler` class

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489773#comment-16489773 ]

Jacques Le Roux commented on OFBIZ-10410:
-----------------------------------------

Thanks Mathieu,

As I say in my commit comment:
bq. jleroux: interesting, it's the 1st use in OFBiz of the "::" syntax for calling methods (cf. https://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.13-500) I note that the string "::" is used in many places as a separator, notably in caches, as  cache key separator but this should not be confusing.

So you made me install Groovy Console 3.0 :)

Your patch is in trunk at revision: 1832199  


> Refactor `JavaEventHandler` class
> ---------------------------------
>
>                 Key: OFBIZ-10410
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10410
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-10410-refactor-java-event-handler.patch
>
>
> Instead of relying on manual synchronisation, use a concurrent map for caching loaded classes.  Inline private `invoke` delegate which intent was fuzzy.  Spread arguments when calling `Method::invoke` and `Class::getMethod`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)