[
https://issues.apache.org/jira/browse/OFBIZ-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519208#comment-16519208 ]
Mathieu Lirzin commented on OFBIZ-10430:
----------------------------------------
Hum I was trusting compilation to detect such issue but indeed at runtime the patch fails.
Here is a version that should work:
{code}
def gradlewSubprocess(commandList) {
def gradlew = os.contains('windows') ? 'gradlew.bat' : './gradlew'
exec { commandLine(gradlew, "--no-daemon", *commandList) }
}
{code}
> Use `in` and spread operator in `gradlewSubprocess`
> ---------------------------------------------------
>
> Key: OFBIZ-10430
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10430> Project: OFBiz
> Issue Type: Improvement
> Reporter: Mathieu Lirzin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10430_Use-in-and-spread-operator-in-gradlewSubprocess.patch
>
>
> No functional change. The idea of using the spread operator is to have less mutation involved. In Groovy, using operator overloads like {{in}} is more idiomatic than using explicitly the associated method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
