[jira] [Commented] (OFBIZ-10437) <#if containerId?has_content> id="${containerId}"</#if> is missed in renderFormOpen

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528777#comment-16528777 ]

Jacques Le Roux commented on OFBIZ-10437:
-----------------------------------------

Hi Wei,

Yes I agree
bq. <#if containerId?has_content> id="${containerId}"</#if>
is missing hence the form id is not provided when containerId has content.

Also the validate block related to containerId is replaced by requireValidation but is missing the {{containerId?has_content}} constraint, which existed previously see [r1832307|http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl?r1=1832307&r2=1832306&pathrev=1832307]
bq. <#if containerId?has_content && hasRequiredField?has_content>

I also noticed
bq. <#if autocomplete?has_content> autocomplete="${autocomplete}"</#if>
is repeated twice

Aditya could you please double check?

> <#if containerId?has_content> id="${containerId}"</#if> is missed in renderFormOpen
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10437
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Wei Zhang
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> <#if containerId?has_content> id="${containerId}"</#if> is missed for renderFormOpen in revision 1832307. And there is no id for html form in rendered html.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)