[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572952#comment-16572952 ]

Taher Alkhateeb commented on OFBIZ-10438:
-----------------------------------------

Great, I think the first step is to get community consensus on the design strategy. I would suggest that I start a thread to explain what is going on, try to explain the situation as best as I can, and then you can also provide your input and we see how the community reacts. Do you like that approach? May I proceed? Or would you like to kick-start the discussion yourself?

> Add method attribute to request-map to controll a uri can be called GET or POST only
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10438
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10438
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Shi Jinghai
>            Assignee: Shi Jinghai
>            Priority: Minor
>         Attachments: OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, OFBIZ-10438_0003-Handle-multiple-request-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> <request-map uri="examples" method="get">
>    <security https="true" auth="true"/>
>    <event type="java" path="ExamplesHandlers" invoke="getExamples"/>
>    <response name="success" type="view" value="..."/>
>    <response name="error" type="view" value="..."/>
> </request-map>
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> <request-map uri="examples" method="get,post">...</request-map>
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)