[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595214#comment-16595214 ]

Jacques Le Roux commented on OFBIZ-10438:
-----------------------------------------

Thanks Mathieu,

I confirm this issue is fixed with [^OFBIZ-10438_Fix-resolveURI.patch]. The problem was r1838081 prevented to serialise requests.

Like in ordermgr/control/updateCheckoutOptions/quickcheckout where updateCheckoutOptions and quickcheckout are serialised to update the check out after updateCheckoutOptions is done and then get back to the screen with quickcheckout.

CheckoutOptions.ftl is a good example of this usage.

I'm not sure if the best way to describe this feature is to say that the view is overridden as you comment in your patch. I would rather say that the views are serialised. But that's OK with me, it makes also sense, and I don't want to be nitpicky today :)

I committed at revision: 1839451  

> Add method attribute to request-map to controll a uri can be called GET or POST only
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10438
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10438
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Shi Jinghai
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, OFBIZ-10438_0003-Handle-multiple-request-methods.patch, OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png, URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> <request-map uri="examples" method="get">
>    <security https="true" auth="true"/>
>    <event type="java" path="ExamplesHandlers" invoke="getExamples"/>
>    <response name="success" type="view" value="..."/>
>    <response name="error" type="view" value="..."/>
> </request-map>
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> <request-map uri="examples" method="get,post">...</request-map>
> {code}
>   
>  

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)