[
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698110#comment-16698110 ]
Pierre Smits commented on OFBIZ-10457:
--------------------------------------
Having done a cursory review of the artefacts in the attached zip file, I found:
* that everything references a specific texting service provider (*msg91* - [
https://msg91.com)|
https://msg91.com)/] instead of using a generic functional name;
* I could not find whether the service provider (Walkover Web Solutions Pvt. Ltd.) operates in other countries than only India;
* a new entity is introduced (*Msg91*GatewayConfig), which seems to be intended to capture (and deliver for the functions) the configuration aspects. This is unnecessary as such parameters can also be in the SystemProperty table.
Though I did not explore this thoroughly I doubt that this would work with other 3rd party SMS solutions. IMO, in order to have this incorporated in the code base some more effort should be applied to make it more generic and applicable to multiple 3rd party SMS solutions. Otherwise this is too 1party specific.
> Short Messaging Service(SMS) Gateway Integration
> ------------------------------------------------
>
> Key: OFBIZ-10457
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10457> Project: OFBiz
> Issue Type: New Feature
> Reporter: Pritam Kute
> Assignee: Rishi Solanki
> Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and can be accessed from here.
>
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
