[
https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534980#comment-16534980 ]
Jacques Le Roux commented on OFBIZ-10458:
-----------------------------------------
Thanks Mathieu, Gil,
Gil you wrote
bq. Import class with an alias to use it can ease java writing, like in your example UtilValidate as Uv. We just need to be careful to use the same all over the code as a convention to keep consistency.
I agree that would quickly get used, who would prefer UtilValidate over Uv :) ? That's easy changed in code with a simple S/R.
bq. You propose to store test classes in a subfolder just under src directory. I think that's a nice idea to separate test code (i remember some discussion about that, but cant figure out yet the details, after some search OFBIZ-4211, but i dont know why this wasnt finished...), this should be discussed in dev mailing list.
This started already 3.5 years ago:
https://markmail.org/message/25dse4jke2fp64mx> GetLocaleList call can provide duplicate results
> ------------------------------------------------
>
> Key: OFBIZ-10458
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10458> Project: OFBiz
> Issue Type: Bug
> Reporter: Mathieu Lirzin
> Assignee: Gil Portenseigne
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10458_0001-Add-failing-tests.patch, OFBIZ-10458_0002-Fix-duplicates-bug.patch, OFBIZ-10458_0003-Refactor.patch
>
>
> This is not a huge issue but I detected an issue with the {{GetLocaleList}} script which when providing both a {{localeString}} and {{localeName}} can provide duplicate results.
> Here is a set of 3 patches that should be applied in order:
> - the first one is adding some tests with a failing one which identifies the bug
> - the second one resolves the bug
> - the third one refactors the code to use a more functional style
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
