[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720206#comment-16720206 ]

Benjamin Jugl commented on OFBIZ-10461:
---------------------------------------

There are in fact a few hard coded   in ftl files acting as spacers between checkbox and text. The case that acts as an example is not one of them.
It is a result of the format that prevents code-lines from being (much) longer than 120 characters. Thus the text will be formated this way:
{code:java}
<label><input type="checkbox" name="view_PURCHASE_ORDER" value="Y"<#if state.hasType('view_PURCHASE_ORDER')>checked="checked"</#if>/>
${descr_PURCHASE_ORDER}</label>
{code}
The linebreak is interpreted as a blank.

Solution: format all occurences like
{code:java}
<label><input type="checkbox" name="view_PURCHASE_ORDER" value="Y"
<#if state.hasType('view_PURCHASE_ORDER')>checked="checked"</#if>/>${descr_PURCHASE_ORDER}</label>
{code}
I will add a comment to the code, that describes the problem, so it will not accidentally get autoformated and commited again.

> Texts of checkboxes sometimes have whitespaces
> ----------------------------------------------
>
>                 Key: OFBIZ-10461
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10461
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Assignee: Benjamin Jugl
>            Priority: Minor
>
> On some pages, when there are checkboxes, the text after the checkbox has a rendered whitespace in front of it.
> A good example for this can be seen right here:
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
> The first checkboxes do not have this rendered whitespace, the lines after that do have it.
> This issue can be fixed simply through removing the whitespaces inside the .ftl files.
>  
> After that there an added styling should create a new gap between the checkbox and the following text, but this time all the gaps would have the same distance.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)