[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538379#comment-16538379 ]
Aditya Sharma commented on OFBIZ-10470:
---------------------------------------
Hi Dennis,
I couldn't get all the 3 variants on orderentry page.
Here is a [link|
https://cwiki.apache.org/confluence/x/lQFk] that might help somewhat.
Maybe I have missed something, but I couldn't find any other link describing the markup pattern. So if we proceed I suggest also updating it if it doesn't exist anywhere else. I feel such information might make it quite easy for someone creating a new theme.
> Inconsistent screenlet-title containers
> ---------------------------------------
>
> Key: OFBIZ-10470
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10470> Project: OFBiz
> Issue Type: Improvement
> Reporter: Dennis Balkir
> Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of screenlet-titles.
> The title is normally nested inside this:
> {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <!-- insert screenlet-title -->
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <div class="h3">Title</div>
> {code}
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <h3>Title</h3>
> {code}
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <ul>
> <li class="h3">Title</li>
> {code}
> All three variants can be found right here:
>
https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
