[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539620#comment-16539620 ]

Dennis Balkir commented on OFBIZ-10470:
---------------------------------------

Hi Jacques,
yes you are right, the screenlets I mentioned are included as FTL files.
I don't think that it will be that easy, to use form widgets all over OFBiz, since FTL files are used so frequently, but at least we can make some kind of convention, that specifies what kind of screenlet titles we are using.

These can also be used in the FTL files and for that the HTML code will be more equal.
Especially if something new is introduced, the commiter can look for these convention and change the title if necessary.

> Inconsistent screenlet-title containers
> ---------------------------------------
>
>                 Key: OFBIZ-10470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10470
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Dennis Balkir
>            Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of screenlet-titles.
> The title is normally nested inside this:
> {code:html}
> <div class="screenlet">
>     <div class="screenlet-title-bar">
>         <!-- insert screenlet-title -->
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
> <div class="screenlet">
>     <div class="screenlet-title-bar">
>         <div class="h3">Title</div>
> {code}
> # {code:html}
> <div class="screenlet">
>     <div class="screenlet-title-bar">
>         <h3>Title</h3>
> {code}
> # {code:html}
> <div class="screenlet">
>     <div class="screenlet-title-bar">
>         <ul>
>             <li class="h3">Title</li>
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather confusing than useful

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)