[jira] [Commented] (OFBIZ-10485) Refactor MapContext

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547927#comment-16547927 ]

Mathieu Lirzin commented on OFBIZ-10485:
----------------------------------------

Hello Taher,

 I have used my IDE to check for references in the workspace.

It is always a hard question since there is no way to actually know and no clear definition of what is part of OFBiz API and what is not.  I have considered{{MapContext}} as internal code since this is a utilitary class and besides the {{ConfigXMLReader}} class and some widget rendering things using {{MapStack}} which extends {{MapContext}} there are no callers inside the framework . So we should be safe

> Refactor MapContext
> -------------------
>
>                 Key: OFBIZ-10485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10485
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: base
>            Reporter: Mathieu Lirzin
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10485_0001-Remove-MapContext-dead-code.patch, OFBIZ-10485_0002-Add-missing-Override-in-MapContext.patch, OFBIZ-10485_0003-Use-the-Deque-interface-in-MapContext.patch, OFBIZ-10485_0004-Rewrite-MapContext-isEmpty.patch, OFBIZ-10485_0005-Rewrite-MapContext-containsKey.patch, OFBIZ-10485_0006-Rewrite-MapContext-keySet.patch, OFBIZ-10485_0007-Remove-MapContext.ListSet-class.patch, OFBIZ-10485_0008-Inline-MapContext-getMapContext.patch, OFBIZ-10485_0009-Rename-stackList-to-maps.patch, OFBIZ-10485_0010-Rework-comments.patch, OFBIZ-10485_0011-Add-entryStream.patch, OFBIZ-10485_0012-Add-withMapContainingKey.patch, OFBIZ-10485_0013-Rewrite-size.patch
>
>
> Following conversion [https://lists.apache.org/thread.htmlf1729ef5eafcf71adfbed0c3ea61dfb73225dff82abc4a57c3de8ed5@%3Cdev.ofbiz.apache.org%3E] on [hidden email].
> Here is a first batch of patches to clean things up. Those patches are meant to be applied in order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)