[
https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560635#comment-16560635 ]
Deepak Dixit commented on OFBIZ-10495:
--------------------------------------
Hi [~Dennis Balkir],
It looks good to me, Some minor suggestion
- We need to update renderContainerBegin and renderContainerEnd for rest of the *ScreenMacroLibrary.ftl files as well (Need to add a new type attribute)
- We can make type as optional in renderContainerBegind and renderContainerEnd
Did you get a chance to test autoUpdateLink with section?
> Rendering different HTML container types with ScreenRenderer
> ------------------------------------------------------------
>
> Key: OFBIZ-10495
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10495> Project: OFBiz
> Issue Type: Improvement
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-10495_modular_container.patch
>
>
> This patch will add an type-parameter to the start and end render macros and methods of HTML containers.
> With this it is possible to not only use {{<div>}} containers, but also use, for example, HTML5's {{<section>}} .
> Simply by using
> {code:xml}
> <container type="section">
> <platform-specific>
> </platform-specific>
> </container>
> {code}
> the renderer will render the container element as the given type.
> If type is left empty, it will always use it's fallback {{<div>}}, and because of this no existing screen in OFBiz needs to be changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
