[
https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561588#comment-16561588 ]
Dennis Balkir commented on OFBIZ-10495:
---------------------------------------
Hi [~deepak.dixit],
I checked mine before uploading, with my solution you could pass any value as type and it would be recognized too.
But I appreciate the changes you made, since I didn't know of some of these files, that also had to be changed, like for example {{FoScreenMacroLibrary}}.
The only thing I don't really understand, is your changed part in {{HtmlScreenMacroLibrary}}. I understand, that this is easier, because type is set with {{div}} as default, which is a lot better than my solution, but at some point you used this:
{code:xml}
<#macro renderContainerEnd type="div"></${div}></#macro>
{code}
In this you used {{div}} as a variable, but I don't see where you get it from? Maybe some mistyping or I just don't get it, maybe you can explain this to me? :D
> Rendering different HTML container types with ScreenRenderer
> ------------------------------------------------------------
>
> Key: OFBIZ-10495
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10495> Project: OFBiz
> Issue Type: Improvement
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-10495.patch, OFBIZ-10495_modular_container.patch
>
>
> This patch will add an type-parameter to the start and end render macros and methods of HTML containers.
> With this it is possible to not only use {{<div>}} containers, but also use, for example, HTML5's {{<section>}} .
> Simply by using
> {code:xml}
> <container type="section">
> <platform-specific>
> </platform-specific>
> </container>
> {code}
> the renderer will render the container element as the given type.
> If type is left empty, it will always use it's fallback {{<div>}}, and because of this no existing screen in OFBiz needs to be changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
