[
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202581#comment-17202581 ]
Jacques Le Roux commented on OFBIZ-10512:
-----------------------------------------
That's right Pradeep,
I was more thinking about moving {{Map<String, ? extends Object> context}} to the end when I "plussed". This said this is very minor and I don't think it's worth the whole refactoring effort if nothing is provided by the reporter. So please feel free to close as "Won't do" if you think so :)
> Change order of parameters in runSyncIgnore
> -------------------------------------------
>
> Key: OFBIZ-10512
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10512> Project: OFBiz
> Issue Type: Wish
> Reporter: Niklas Fallik
> Priority: Minor
>
> It is confusing that the order of the arguments passed to LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> cf.
> {code:java}
> void runSyncIgnore(String serviceName, Map<String, ? extends Object> context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
> {code}
>
> {code:java}
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean requireNewTransaction, Object... context) throws ServiceAuthException, ServiceValidationException, GenericServiceException; {code}
> cf.
> LocalDispatcher.java[101 + 102]
>
> The context parameter could be passed as second or as fourth argument, no matter if it is a Map or an Object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
