[
https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625529#comment-16625529 ]
Taher Alkhateeb commented on OFBIZ-10515:
-----------------------------------------
Much better! Your shortened code is now showing how bad the original userLogin function is :) We probably need to refactor that thing at some point. It's a bit long for my taste, but more readable and the documentation makes things easier on the eyes.
Thank you for your dedication to this Gil. I will take this chance to say it's really good to work with ya again :)
> Impersonation of userLogin feature
> ----------------------------------
>
> Key: OFBIZ-10515
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10515> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Gil Portenseigne
> Assignee: Gil Portenseigne
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: ImpersonationWidget.png, OFBIZ-10515.patch, OFBIZ-10515.patch, OFBIZ-10515.patch, OFBIZ-10515.patch, OFBIZ-10515.patch, impersonate-ico.png, impersonateButton.png
>
>
> This JIRA introduce a new feature that allow the impersonation of a login by an authorized user.
> This is implemeted with :·
> * A new service ‘userImpersonate’ that will check security, store impersonation in UserLoginHistory, and return the new session
> * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow impersonation/depersonation action persisting current user session
> * A new modal widget in the common-theme that inform the user about ‘impersonation in process’ and offering a way to depersonate.
> * A new field in UserLoginHistory to store impersonation originator
> * A button in party viewprofile page to illustrate the feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
