[jira] [Commented] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614780#comment-16614780 ]

Gil Portenseigne commented on OFBIZ-10566:
------------------------------------------

{quote} What about ecommerce, maybe also in webtools?{quote}
I check the presence of all ‘ findOne’ usage into groovy. And rewrite them, if I missed some do not hesitate to tell me which one :).
Even if i missed some, the findOne method is still implemented (marked deprecated), then that will not cause any issue at execution.

{quote} Is it normal to remove findList from OfbizDslDescriptorForEclipse?{quote}

yes, since it's no more implemented in ‘GroovyBaseScript.groovy’


> Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10566
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10566
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Gil Portenseigne
>            Assignee: Gil Portenseigne
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10566.patch
>
>
> While studying groovy DSL possibilities i stumbled upon missing descriptors in Intellij gdsl.
> Cleaning intellij and eclipse descriptors, i checked all implementations and find out that findAll do not exist anymore, surely thanks to EntityQuery improvement.
> I wondered then why there remain a findOne method, since EntityQuery is here.
> I propose to deprecate it for next release (18.??) and remove it from next one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)