[
https://issues.apache.org/jira/browse/OFBIZ-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620717#comment-16620717 ]
Jacques Le Roux commented on OFBIZ-10569:
-----------------------------------------
Hi Dennis,
This code is from pre Apache era and has been a slightly modified since (eg r741374 and OFBIZ-10438). I made the documentation at r1347762. At r741742 the log message, from pre Apache era, has been confirmed to be "Response is a Cross-Application redirect". AFAIK there are never been any examples OOTB. I'm not even sure I even used it myself when I documented it (I then used "url").
I believe now I was wrong when I wrote this line:
bq. Works like URL but you can also pass redirected parameters.
Because AFAIU "cross-redirect" should be used only "internally". As the log mentions, it's a *cross applications* (ie for OFBiz internal webapps) redirect. It's not like "url" where all is allowed (ie open external calls - with possible parameters in URL - under writer's responsability). So I think we should rather amend the documentation. I suggest:
bq. Works like request-redirect for cross applications calls.
Then the code makes sense.
Does it makes sense to you?
> Wrong handling of response type "cross-redirect"
> ------------------------------------------------
>
> Key: OFBIZ-10569
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10569> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-10569_RequestHandler.patch
>
>
> When using the response type "cross-redirect", OFBiz is not acting as expected.
> The description of the types "url" and "cross-redirect" is stated as follows in the file {{site-conf.xsd}}:
> {code:xml}
> <xs:enumeration value="url">
> <xs:annotation>
> <xs:documentation>
> Any URL, relative or absolute. Redirected parameters are not used, you can put them in the url.
> </xs:documentation>
> </xs:annotation>
> </xs:enumeration>
> <xs:enumeration value="cross-redirect">
> <xs:annotation>
> <xs:documentation>
> Works like URL but you can also pass redirected parameters.
> </xs:documentation>
> </xs:annotation>
> </xs:enumeration>
> {code}
> The way, this is implemented in {{RequestHandler.java}} works slightly different:
> For the type "url", this is true, but for "cross-redirect", before putting the params in the link, it is checked, if the link begins with an "/".
> If not, it is added as the first char.
> This results in a link given like this: {{
https://test.com}}
> will turn into this: {{/
https://test.com}}, which will then be treated as an OFBiz internal link, like {{/catalog}}, and instead of be called externally, OFBiz tries to call it as an OFBiz-URL.
> This behavior is not correct and should therefore be corrected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
