[
https://issues.apache.org/jira/browse/OFBIZ-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621626#comment-16621626 ]
Dennis Balkir commented on OFBIZ-10569:
---------------------------------------
Hi Jacques,
yes this makes sense to me.
But on the other hand, this means, that there simply is no possibility to address an external url with params, which would be quite restrictive.
Since there are already different ways to open an internal url with params, why not use this, or maybe make a new type, for external url with params?
This is documented this way, even if the documentation is wrong, but it gives us the opportunity, to use it that way it could be used.
I see no problem in changing the code, if the documentation already states, that it is used that way and since there are other types to open urls internally.
> Wrong handling of response type "cross-redirect"
> ------------------------------------------------
>
> Key: OFBIZ-10569
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10569> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-10569_RequestHandler.patch
>
>
> When using the response type "cross-redirect", OFBiz is not acting as expected.
> The description of the types "url" and "cross-redirect" is stated as follows in the file {{site-conf.xsd}}:
> {code:xml}
> <xs:enumeration value="url">
> <xs:annotation>
> <xs:documentation>
> Any URL, relative or absolute. Redirected parameters are not used, you can put them in the url.
> </xs:documentation>
> </xs:annotation>
> </xs:enumeration>
> <xs:enumeration value="cross-redirect">
> <xs:annotation>
> <xs:documentation>
> Works like URL but you can also pass redirected parameters.
> </xs:documentation>
> </xs:annotation>
> </xs:enumeration>
> {code}
> The way, this is implemented in {{RequestHandler.java}} works slightly different:
> For the type "url", this is true, but for "cross-redirect", before putting the params in the link, it is checked, if the link begins with an "/".
> If not, it is added as the first char.
> This results in a link given like this: {{
https://test.com}}
> will turn into this: {{/
https://test.com}}, which will then be treated as an OFBiz internal link, like {{/catalog}}, and instead of be called externally, OFBiz tries to call it as an OFBiz-URL.
> This behavior is not correct and should therefore be corrected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
