[
https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624506#comment-16624506 ]
Girish Vasmatkar commented on OFBIZ-10571:
------------------------------------------
Following refactoring done -
* Refactored code to fall in line with some java standards.
* Based on FindBugs suggestion, refactored some classes to have static nested classes instead of inner class.
> [FB] Package org.apache.ofbiz.minilang
> --------------------------------------
>
> Key: OFBIZ-10571
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10571> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Affects Versions: Trunk
> Reporter: Girish Vasmatkar
> Assignee: Girish Vasmatkar
> Priority: Minor
> Attachments: OFBIZ-10571.patch
>
>
> * [Should be a static inner class|
http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC]
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC*
> *org.apache.ofbiz.minilang.method.callops.CallService***
>
> * [Could be refactored into a named static inner class|
http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON]
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made into a _static_ inner class. Since anonymous inner classes cannot be marked as static, doing this will require refactoring the inner class so that it is a named inner class.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON*
> *org.apache.ofbiz.minilang.method.conditional.CombinedConditional*
>
> * [Boxing/unboxing to parse a primitive|
http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING]
> A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method.
> **
> *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING*
> *org.apache.ofbiz.minilang.method.otherops.Calculate*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
