[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709892#comment-16709892 ]

Mathieu Lirzin commented on OFBIZ-10579:
----------------------------------------

Thanks [~suraj.khurana] for the explanation. Instead of warning that the wrong thing was done, shouldn't we do the right thing meaning not putting the query in the cache and letting the caller know with the return value of the {{put}} method?  The returned value could be {{null}} or {{Optional.empty()}} in the "date filtering" case for example.

> Date filtered queries with caching should be restricted to cache
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-10579
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10579
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Upcoming Branch
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)