[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788599#comment-16788599 ]

Suraj Khurana commented on OFBIZ-10579:
---------------------------------------

Hello all,

Actually it was a work around which was introduced earlier to entertain filterBayDate when used with useCache, usingCache in makeWhereCondition is not making any sense.

Removing 
{code:java}
if (filterByDate && useCache) {
    return EntityUtil.filterByCondition(result, this.makeDateCondition());
}
{code}
 This is because, now makeWhereCondition method will take case of filterByDate already if used with useCache parameter.

I hope it is making sense now.
Looking forward to hearing from you.


Thanks in advance !!

> Date filtered queries with caching should be restricted to cache
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-10579
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10579
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Upcoming Branch
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)