[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817962#comment-16817962 ]

Jacques Le Roux commented on OFBIZ-10579:
-----------------------------------------

Hi All,

After reading the thread (started by Scott, who also puts the EntityQuery stuff in place), I reviewed the patch and it looks good to me. Now I tend to agree with Mathieu.

# Would it not be better to prevent such behaviour at the root. when the dev create and hopefully test it? I mean rather than only sending a message in the log, also, as suggested by Mathieu, block the code to force the dev to understand what s/he is doing wrong?
# Optionnaly having tests. Though we don't force that in OFBiz there are always welcome. Again not a necessity, just better if possible and resaonnable

> Date filtered queries with caching should be restricted to cache
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-10579
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10579
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Upcoming Branch
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)