[jira] [Commented] (OFBIZ-10605) Creating Javadoc on WIndows fails

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649981#comment-16649981 ]

Jacques Le Roux commented on OFBIZ-10605:
-----------------------------------------

While working on OFBIZ-10603 I stumbled upon this error. It's easily fixed by adding {{encoding "UTF-8"}} to {{javadoc.options}} block.

I also saw at [https://github.com/nebula-plugins/gradle-aggregate-javadocs-plugin/issues/6] that we could use
{code}
 docEncoding "UTF-8"
 charSet "UTF-8"
 linkSource true
{code}
I [checked|https://docs.oracle.com/javase/8/docs/technotes/tools/windows/javadoc.html#CHDCIBFC].
* If you use encoding, docEncoding is redundant.
* charset can be added, not a big deal
* I still wonder about linksource. It could be interesting but why it's not OOTB, there must be a reason. I could not find it. So as the maxim says "When in doubt, abstain".

I saw in the link above that {{failOnError = true}} is in the {{javadoc.options}} block. But it's not a Javadoc option. So I did not move it there.

> Creating Javadoc on WIndows fails
> ---------------------------------
>
>                 Key: OFBIZ-10605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10605
>             Project: OFBiz
>          Issue Type: Bug
>          Components: Gradle
>    Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> The error is:
> {code:java}
> :classes
> :javadoc
> C:\projectsASF\ofbiz\framework\common\src\main\java\org\apache\ofbiz\common\UrlServletHelper.java:247: error: unmappable character for encoding Cp1252
>         str = str.replace("´╝?", "-");
>                              ^
> C:\projectsASF\ofbiz\framework\common\src\main\java\org\apache\ofbiz\common\UrlServletHelper.java:253: error: unmappable character for encoding Cp1252
>         str = str.replace("ÒÇ?", "-");
>                              ^
> C:\projectsASF\ofbiz\framework\common\src\main\java\org\apache\ofbiz\common\UrlServletHelper.java:256: error: unmappable character for encoding Cp1252
>         str = str.replace("´¢?", "-");
>                              ^
> C:\projectsASF\ofbiz\framework\common\src\main\java\org\apache\ofbiz\common\UrlServletHelper.java:260: error: unmappable character for encoding Cp1252
>         str = str.replace("ÒÇ?", "-");
>                              ^
> 4 errors
> :javadoc FAILED{code}

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)