[
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740303#comment-16740303 ]
Michael Brohl commented on OFBIZ-10607:
---------------------------------------
{quote}Can you explain the issue with the patch I submitted?
{quote}
The patch format itself had no issue, but the patchfile itself contains more than the patch. It seems it contains some surrounding email content.
Depending on the IDE used, this breaks automatic patch application. It's better to only have the raw diff information inside the patch file to avoid extra work for the reviewer/committer.
> ‘EntityOperator#getId()’ is not used in the framework
> -----------------------------------------------------
>
> Key: OFBIZ-10607
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10607> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Michael Brohl
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a test demonstrated its purpose and describing how to use it. Otherwise we should simply delete it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
