[jira] [Commented] (OFBIZ-10632) ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666830#comment-16666830 ]

Jacques Le Roux commented on OFBIZ-10632:
-----------------------------------------

Morning Mathieu,

Agreed, the solution is maybe to have an user's preference for the fixed locale with a default as a properties or a system data.

We could use initialLocaleComplete for that, in MinimalActions screen:
{code}
<set field="initialLocaleComplete" type="String" value="${groovy:parameters?.userLogin?.lastLocale}" default-value="${groovy:locale.toString()}" global="true"/>
{code}

> ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10632
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10632
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10632_Use-String-toLowercase-and-String-toUppercase-when-p.patch
>
>
> Usage of {{"foo".toLowerCase()}} should be preferred to {{"foo".toLowerCase(Locale.getDefault())}} which is equivalent but more verbose. Likewise for {{toUpperCase()}}.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)