[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863111#comment-16863111 ]

Jacques Le Roux commented on OFBIZ-10639:
-----------------------------------------

Deepak,
{quote}By keeping in mind about MIT license, I changed the name of variables to make them more relevant to the functionality. However, we can keep the previous name also. I also removed some code from the plugin which is not required in our case. I am not sure if we can add OFBiz license header files for the customized files having MIT license. Please help me with this.
{quote}
In any cases (as is, or customised) we need a notice in LICENSE file. I believe adding a line in the ""jQuery"" section should be OK. BTW I wonder if the state is correct there after the move to common-theme...
 Now about customising the code, is that required? Else I'd be in favor of letting it as is even it contains not used code. If we modify it, I don't think it's right to change the license. Because we then modify a work and don't create a new one. A small comment specifying what is modified should be enough. Also then the name should contain "custom" as we have jquery-ui-1.8.13.custom.css, easier for possible later maintenance.
{quote}Changes in custom.css files are copied from Example.css but I made some customizations for a better look and feel.
{quote}
Same than above
{quote}This patch was created from the root of the e-commerce plugin. I am able to apply it from there.
{quote}
Yes me too, that's how I tested, it's not a big deal. By root I mean OFBiz root. Else we get patches from either plugins root or a plugin component root. Sincerely it's easy to handle, just easier to have all patches created from OFBiz root.
{quote}By custom code in Init.js, I mean initialization blocks of other plugins and libraries. It will be a common file for all initialization blocks. However, initCookieConsent.js is also fine we want to keep it specific to this cookie consent feature.
{quote}
OK it makes sense. For now it's only CookieConsent so I think it's easier to rename it initCookieConsent. We can rename it init.js later when we will add other inits. A TODO about that should be put in the file.

> Cookie Consent In E-Commerce
> ----------------------------
>
>                 Key: OFBIZ-10639
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10639
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: Trunk
>            Reporter: Deepak Nigam
>            Assignee: Swapnil M Mane
>            Priority: Minor
>         Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch
>
>
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to get consent from visitors to store or retrieve any information on their computer, smartphone or tablet. It was designed to protect online privacy, by making consumers aware of how information about them is collected and used online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some variation on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use cookies:
>  1. When someone visits your website, you need to let them know that your site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the use of cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on their machine.
>  
>  For more information about EU cookie policy, please visit [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we should work towards its implementation. There are numerous open-source jQuery plugins available which we can use.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)