[jira] [Commented] (OFBIZ-10642) Fallthrough in switch-case of org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10642) Fallthrough in switch-case of org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681036#comment-16681036 ]

Pierre Smits commented on OFBIZ-10642:
--------------------------------------

This feature should be disentangled from the core and live as a separate component in the plugin repo.

> Fallthrough in switch-case of org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.java
> ----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10642
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10642
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Benjamin Jugl
>            Assignee: Benjamin Jugl
>            Priority: Minor
>         Attachments: OFBIZ-10642_fallthrough_in_switchcase.patch
>
>
> org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse.GatewayResponse(InputStream, GatewayRequest):
> Line 157 et. seq.:
> Breaks missing in switch case.
> As this particular one replaces an if-else construct, these should be added.
> I will provide a patch withi a short time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)