[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708249#comment-16708249 ]

Deepak Dixit commented on OFBIZ-10689:
--------------------------------------

Hi Jacques,

I think ObjectType.simpleTypeConvert supports the BigDecimal conversion, (Please refer ModelFormField.java:1552) There are lots of occurrences in code.


ObjectType.simpleTypeConvert(retVal, "BigDecimal", null, null, locale, true);

parseBigDecimalForEntity does not support the locale based conversion.

 

> function parseBigDecimalForEntity is in wrong location
> ------------------------------------------------------
>
>                 Key: OFBIZ-10689
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10689
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, Release Branch 17.12
>            Reporter: Pierre Smits
>            Priority: Major
>
> Currently the function 'parseBigDecimalForEntity' is located in ProductEvents.java. 
> Given that this function applies to more than just products, this function should be located in the framework stack.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)