[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708403#comment-16708403 ]

Jacques Le Roux commented on OFBIZ-10689:
-----------------------------------------

I can't find any
bq. ObjectType.simpleTypeConvert(retVal, "BigDecimal", null, null, locale, true);
But a lot of {{ObjectType.simpleTypeConvert(*, "BigDecimal"}}. So it's indeed the right solution.

We should amend Javadoc and name it's misleading. What about changing to {{simpleTypeOrObjectConvert}}, see attached  [^OFBIZ-10689-simpleTypeOrObjectConvert.patch] . If  we agree I can also convert {{parseBigDecimalForEntity}}

> function parseBigDecimalForEntity is in wrong location
> ------------------------------------------------------
>
>                 Key: OFBIZ-10689
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10689
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, Release Branch 17.12
>            Reporter: Pierre Smits
>            Priority: Major
>         Attachments: OFBIZ-10689-simpleTypeOrObjectConvert.patch
>
>
> Currently the function 'parseBigDecimalForEntity' is located in ProductEvents.java. 
> Given that this function applies to more than just products, this function should be located in the framework stack.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)