[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741261#comment-16741261 ]

Jacques Le Roux commented on OFBIZ-10692:
-----------------------------------------

Hi Leila,

In trunk the error I see when applyin the test patch in UI is:
{quote}Le paramètre requis suivant manque : [updateFXConversion.conversionFactor]
{quote}
In log:
{noformat}
2019-01-12 12:37:15,115 |jsse-nio-8443-exec-3 |ServiceDispatcher |E| Incoming context (in runSync : updateFXConversion) does not match expected requirements
 org.apache.ofbiz.service.ServiceValidationException: Le paramÞtre requis suivant manque : [updateFXConversion.conversionFactor]
 at org.apache.ofbiz.service.ModelService.validate(ModelService.java:575) ~[ofbiz.jar:?]
{noformat}

After applying the patch inEclipse (fuzz 5, it's not an up to date trunk patch) I get the same message. So please check with an updated trunk, because we only apply improvements over the trunk, thanks.

> Groovy DSL runService Exception Management
> ------------------------------------------
>
>                 Key: OFBIZ-10692
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10692
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Leila Mekika
>            Assignee: Gil Portenseigne
>            Priority: Minor
>              Labels: patch
>         Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread : [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>   
>  This ticket try to improve the way that errors are rendered when using {{run service}} groovy DSL method.
>  
>  To reproduce and test patch:
>  apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on createUomConversionDated service) and try to create a conversion rate with a fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>   
>  You should then see the following error:
>      The Following Errors Occurred: Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be same or smaller than from date)
>   
>  With  [^OFBIZ-10692.patch]  update, the error must be displayed like:
>      The Following Errors Occurred: Through date can't be same or smaller than from date
>   

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)