[jira] [Commented] (OFBIZ-10697) ControlEventListener improvement: check debug level

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10697) ControlEventListener improvement: check debug level

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713988#comment-16713988 ]

Michael Brohl commented on OFBIZ-10697:
---------------------------------------

> we agreed about better doing a check when using Debug.logVerbose().

Yes, that's why I think that we should do the checks instead of just using Debug.logXxx. The ControlEventListener is called quite often.

I don't think that we should remove the checks already implemented. And following the pattern, I would also do the preceding check for Debug.logInfo to optimize for production settings.

> ControlEventListener improvement: check debug level
> ---------------------------------------------------
>
>                 Key: OFBIZ-10697
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10697
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk, Release Branch 17.12
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> The Debug.logXXX statements should be preceded with a check for the debug level to optimize the performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)