[
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782434#comment-16782434 ]
Mathieu Lirzin commented on OFBIZ-10700:
----------------------------------------
Hello [~shi.jinghai],
According to the [Gradle doc|
https://docs.gradle.org/current/userguide/plugins.html#sec:subprojects_plugins_dsl] the change you are proposing is about separating the *resolution* and the *application* of the {{org.owasp.dependencycheck}} which is useful in multi-project builds where you want to apply a plugin only to a subset of subprojects. I guess (without testing) that plugins *resolution* mean that the plugin is downloaded which in our case would be better to avoid as long as the {{enableOwasp}} property is not provided. As a consequence If this guess is correct I would prefer to keep the {{plugins}} block inside the {{if}} otherwise I will be fine with the version you are proposing. Please correct me if I am making a wrong guess or missing some other obvious advantage of the second form.
Thanks
> Use the Gradle Plugin DSL
> -------------------------
>
> Key: OFBIZ-10700
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10700> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method. See [here|
https://docs.gradle.org/current/userguide/plugins.html] for more details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
