[jira] [Commented] (OFBIZ-10706) EmailServices.sendMail causes a NPE, when sendFrom is missing

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776639#comment-16776639 ]

Deepak Dixit commented on OFBIZ-10706:
--------------------------------------

My Comments from Dev List:

>>{color:#222222}+1, Its good to make sendFrom mandatory for sendMail service. {color}

After reviewing sendMail implementation, I agree with Scott, we have defaultFromEmailAddress in general.properties file, we can use it instead of making sendFrom madatory.

 

> EmailServices.sendMail causes a NPE, when sendFrom is missing
> -------------------------------------------------------------
>
>                 Key: OFBIZ-10706
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10706
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Benjamin Jugl
>            Assignee: Benjamin Jugl
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10706_services_Email.xml.patch
>
>
> Because the Error occurs further down in Java, there are two options
>  # Either catch the NPE in sendMail and try to send a mail without a sendFrom field (I doubt that this will work)
>  # Or expand the sendMailOnePartInterface to have sendFrom mandatory just like sendTo
>  

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)