[jira] [Commented] (OFBIZ-10706) EmailServices.sendMail causes a NPE, when sendFrom is missing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10706) EmailServices.sendMail causes a NPE, when sendFrom is missing

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797081#comment-16797081 ]

Pawan Verma commented on OFBIZ-10706:
-------------------------------------

I tried to find the history for why the service does not take the defaultFromEmailAddress property from general.properties and I found that It was last modified in revision *r418498 on 02/07/2006*, I think it was always broken.

 

I have attached a patch to use defaultFromEmailAddress property in sendMail if sendFrom is missing, instead making it mandatory.

> EmailServices.sendMail causes a NPE, when sendFrom is missing
> -------------------------------------------------------------
>
>                 Key: OFBIZ-10706
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10706
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Benjamin Jugl
>            Assignee: Pawan Verma
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10706.patch, OFBIZ-10706_services_Email.xml.patch
>
>
> Because the Error occurs further down in Java, there are two options
>  # Either catch the NPE in sendMail and try to send a mail without a sendFrom field (I doubt that this will work)
>  # Or expand the sendMailOnePartInterface to have sendFrom mandatory just like sendTo
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)