[jira] [Commented] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725723#comment-16725723 ]

Jacques Le Roux commented on OFBIZ-10724:
-----------------------------------------

+1 all such patterns should be improved the same way, thanks Aditya

> Refactor ServiceUtil.isSuccess() method
> ---------------------------------------
>
>                 Key: OFBIZ-10724
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10724
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Minor
>         Attachments: OFBIZ-10724.patch
>
>
> Following lines:
> {code:java}
> if (ServiceUtil.isError(results) || ServiceUtil.isFailure(results)) {
> return false;
> }
> return true;
> {code}
> can be changed to
> {code:java}
> return !(ServiceUtil.isError(results) || ServiceUtil.isFailure(results));
> {code}

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)