[
https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728314#comment-16728314 ]
Jacques Le Roux commented on OFBIZ-10745:
-----------------------------------------
Hi Aditya,
I think you can commit directly for all these simple kind of changes. They are straightforward and we can always [commit then review (CTR)|
https://www.apache.org/foundation/glossary.html#CommitThenReview] which is the way OFBiz works (see also start of
https://www.apache.org/dev/new-committers-guide.html#guide-for-new-committers). Only for big changes we prefer to ask reviews before commit. The frontier is normaly esier to see: if it's a pain to review, or you have a doubt, then better ask others to do it before commit I'd say.
Thanks
> Refactor boolean returns for ShoppingCart methods
> --------------------------------------------------
>
> Key: OFBIZ-10745
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10745> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Aditya Sharma
> Assignee: Aditya Sharma
> Priority: Minor
> Attachments: OFBIZ-10745.patch, OFBIZ-10745.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
