[jira] [Commented] (OFBIZ-10753) Improve error message page to support Theming

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806135#comment-16806135 ]

Jacques Le Roux commented on OFBIZ-10753:
-----------------------------------------

Hi Nicolas, I created OFBIZ-10895 for that. The feature is not related, there are just 2 points and the 2nd is someone related but not a problem.
# The failing URL is generated not typed by hand
# though the error page is called it does not show (which is actually good, since it's not an user error, so nothing in UI is good)

> Improve error message page to support Theming
> ---------------------------------------------
>
>                 Key: OFBIZ-10753
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10753
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>         Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> <errorpage>/error/error.jsp</errorpage>{code}
> This method isn't support by the theming. I propose two improvements :
>  * use FlexibleLocation to resolve the error page :
> {code:java}
> <errorpage>component://common/webcommon/error/error.ftl</errorpage>{code}
>  * improve theme to support the error message page   
> {code:java}
>   <template name="screen" type="html" content-type="UTF-8" encoding="none" encoder="html" compress="false">
>   <template-file widget="screen" location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>   <template-file widget="form" location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>   <template-file widget="tree" location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>   <template-file widget="menu" location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + <template-file widget="error" location="component://common-theme/template/ErrorPage.ftl"/>
> </template>{code}
> By the way you can define your error page by the theme in first step and we would use the rendering type in future to display the error no only in html

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)