[jira] [Commented] (OFBIZ-10753) Improve error message page to support Theming

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042895#comment-17042895 ]

ASF subversion and git services commented on OFBIZ-10753:
---------------------------------------------------------

Commit f5c92c053c500737b2dfcc0422dba1bd6ff99783 in ofbiz-framework's branch refs/heads/release17.12 from Deepak Dixit
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f5c92c0 ]

Added missing ErrorPage.ftl file
(OFBIZ-10753)

> Improve error message page to support Theming
> ---------------------------------------------
>
>                 Key: OFBIZ-10753
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10753
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>             Fix For: 17.12.01, 18.12.01
>
>         Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> <errorpage>/error/error.jsp</errorpage>{code}
> This method isn't support by the theming. I propose two improvements :
>  * use FlexibleLocation to resolve the error page :
> {code:java}
> <errorpage>component://common/webcommon/error/error.ftl</errorpage>{code}
>  * improve theme to support the error message page   
> {code:java}
>   <template name="screen" type="html" content-type="UTF-8" encoding="none" encoder="html" compress="false">
>   <template-file widget="screen" location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>   <template-file widget="form" location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>   <template-file widget="tree" location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>   <template-file widget="menu" location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + <template-file widget="error" location="component://common-theme/template/ErrorPage.ftl"/>
> </template>{code}
> By the way you can define your error page by the theme in first step and we would use the rendering type in future to display the error no only in html

--
This message was sent by Atlassian Jira
(v8.3.4#803005)