[
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777817#comment-16777817 ]
Taher Alkhateeb commented on OFBIZ-10757:
-----------------------------------------
I think bumping java to 11 should be done _after_ Deepak completes his prep work. His commit is more of a preparation for java 11, so perhaps it might be cleaner to avoid mixing concepts in one commit.
On the other hand, the patch looks much better. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)