[jira] [Commented] (OFBIZ-10768) Cannot sort fields of a form if it has a parent

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10768) Cannot sort fields of a form if it has a parent

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735201#comment-16735201 ]

Taher Alkhateeb commented on OFBIZ-10768:
-----------------------------------------

The attached patch fixes the issue. In essence, the bug was that a form is pointing to its parent targetType field instead of its parameter sortField. This caused this weird bug which is addressed with this patch.

I will wait a few days before committing hoping folks can help with the review.

> Cannot sort fields of a form if it has a parent
> -----------------------------------------------
>
>                 Key: OFBIZ-10768
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10768
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-10768.patch
>
>
> To repeat the bug:
>  * Create a form with a few fields and do not set the sort-field-parameter-name attribute
>  * Create another form that extends from this form and again do not set the sort-field-parameter-name attribute
>  * Now make any field sortable by setting sort-field="true"
>  * Observe how the link is broken. instead of having sortField=whatever in the URL, instead you would get intra-app=whatever. Thus sort field functionality becomes broken.
> After investigating this issue, I realized the reason was an error in the ModelForm.java file. I will provide a patch for a fix.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)