[
https://issues.apache.org/jira/browse/OFBIZ-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737239#comment-16737239 ]
Taher Alkhateeb commented on OFBIZ-10768:
-----------------------------------------
Hi Gil,
I think you are correct, I guess my brain is a little fried today :) Sorry for jumping to a conclusion too quickly.
However, May I suggest maybe to rewrite the logic to make it a bit easier to read as shown below? What do you think? Does it look better?
{code:java}
if (!sortFieldParameterName.isEmpty()) {
this.sortFieldParameterName = sortFieldParameterName;
} else if (parentModel != null){
this.sortFieldParameterName = parentModel.getSortFieldParameterName();
} else {
this.sortFieldParameterName = "sortField";
}
{code}
> Cannot sort fields of a form if it has a parent
> -----------------------------------------------
>
> Key: OFBIZ-10768
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10768> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Reporter: Taher Alkhateeb
> Priority: Minor
> Attachments: OFBIZ-10768.patch
>
>
> To repeat the bug:
> * Create a form with a few fields and do not set the sort-field-parameter-name attribute
> * Create another form that extends from this form and again do not set the sort-field-parameter-name attribute
> * Now make any field sortable by setting sort-field="true"
> * Observe how the link is broken. instead of having sortField=whatever in the URL, instead you would get intra-app=whatever. Thus sort field functionality becomes broken.
> After investigating this issue, I realized the reason was an error in the ModelForm.java file. I will provide a patch for a fix.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
