[jira] [Commented] (OFBIZ-10776) Change 'uiLabelMap' requirement in Framework code

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737518#comment-16737518 ]

Gil Portenseigne commented on OFBIZ-10776:
------------------------------------------

Hi [~pfm.smits], do you have some measurement or data to show up the effect of renaming uiLabelMap to lm in the codebase ? I'm curious about the result.
Actually, I'd like to avoid introducing new cryptic names, and the fact that there are already some existant should not, in my opinion, justify it.

I agree about the lean and mean, but i prefer to have something more readable even if more verbose.

If reducing uiLabelMap variable name as some sensible effect, i would sugest to replace it with ‘label’, that keep some sense.

> Change 'uiLabelMap' requirement in Framework code
> -------------------------------------------------
>
>                 Key: OFBIZ-10776
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10776
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Minor
>
> Reducing byte size of  'uiLabelMap' from code elements in Framework will lead to significant saves in widgets, templates and functions downstream.
> See https://github.com/PierreSmits/ofbiz-framework/commit/438e9c45eede9c7036ba9e658036085908dce09d

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)