[jira] [Commented] (OFBIZ-10808) Inline ‘serviceInvoker’ method in Groovy engine

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741895#comment-16741895 ]

Mathieu Lirzin commented on OFBIZ-10808:
----------------------------------------

I have included  [^OFBIZ-10808.patch] which inlines the {{serviceInvoker}} method and do some trivial rewriting/reformatting.

> Inline ‘serviceInvoker’ method in Groovy engine
> -----------------------------------------------
>
>                 Key: OFBIZ-10808
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10808
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Priority: Trivial
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10808.patch
>
>
> The {{runSync}} method of the Groovy engine is only passed its arguments to the {{serviceInvoker}} method which is private and used only by the {{runSync}} method. As a consequence it seems preferable to inline the {{serviceInvoker}} method.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)