[
https://issues.apache.org/jira/browse/OFBIZ-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747204#comment-16747204 ]
Jacques Le Roux commented on OFBIZ-10811:
-----------------------------------------
Hi Suraj,
It globally looks good to me, just few questions (bear with me I simply reviewed and did not get into much details, like checking calls)
# Why a try block for captureAmount and not processAmount?
# Why a try block for the 1st processAmount and not the 2nd?
# Why removing the try block for
payToPartyId = getBillingInformation(orh, paymentPref, new HashMap<String, Object>());
and replacing it by
String payToPartyId = orh.getBillToParty().getString("partyId");
?
Thanks
> PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables
> --------------------------------------------------------------------------------------------
>
> Key: OFBIZ-10811
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10811> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Suraj Khurana
> Assignee: Suraj Khurana
> Priority: Major
> Attachments: OFBIZ-10811.patch
>
>
> Currently, it is direct typecasting into BigDecimal and it could throw exception regarding string to BigDecimal typecasting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
