[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859228#comment-16859228 ]

Mathieu Lirzin commented on OFBIZ-10817:
----------------------------------------

Lambda expressions are not meant to be stored inside variables.  In most cases it is better to define a static method and use a method reference instead.  Static methods have the benefits of having a more
explicit signature and some javadoc attached to them.

I have included  [^OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch] which is rewriting current implementing to use method references.

If nobody disagrees I will commit the patch in a couple of days.

> Configure stackTrace displaying on ftl rendering
> ------------------------------------------------
>
>                 Key: OFBIZ-10817
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10817
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, OFBIZ-10817.patch, OFBIZ-10817.patch, OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, Sélection_236.png, Sélection_237.png
>
>
> Currently when freemarker failed to execute a template, you have on end screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property widget.verbose is true, no regression during development and when you switch to production site, in general your widget.verbose is false so end user haven't stack trace (that totally unused for them).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)