[
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799596#comment-16799596 ]
Jacques Le Roux commented on OFBIZ-10866:
-----------------------------------------
Hi Mathieu,
bq. Renaming the gradlew wrapper ofbiz would be really confusing since they are not the same program.
I'm not opiniated about that, but we can be creative and have our own conventions. We could just put a comment in the scripts to explain why. Anyway it's really a minor thing and I'll not push more about that.
bq. This is not the case at all, the patch I am proposing is only adding the run task and suggesting in the README.adoc to use it, I am not removing the ./gradlew "ofbiz ..." rule tasks, so scripts will not break.
In your last patch it's not the case indeed. Do you plan to propose the "run changes" in another Jira or patch or did you gave up?
Anyway +1 for your last patch! I did not test it all but it's simple and clear.
> Use the ‘application’ and ‘distribution’ plugins
> ------------------------------------------------
>
> Key: OFBIZ-10866
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10866> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for packaging applications via the ‘distribution’ and ‘application’ plugins.
> * The ‘distribution’ plugin [1] is providing a straightforward and easy way to distribute OFBiz with its dependencies which is convenient in a deployment context. This is achieved by the new ‘distTar’ and ‘distZip’ tasks.
> * The ‘application’ plugin [2] is complementing the ‘distribution’ plugin by adding both a robust shell script and a batch script inside the distribution archives to allow launching OFBiz easily.
> [1]
https://docs.gradle.org/current/userguide/distribution_plugin.html> [2]
https://docs.gradle.org/current/userguide/application_plugin.html--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
