[jira] [Commented] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799947#comment-16799947 ]

Jacques Le Roux commented on OFBIZ-10872:
-----------------------------------------

Sorry Mathieu,

For a reason the patch does not apply:

Jacques@LDLC MINGW64 /c/projectsASF/ofbiz
$ patch -p0 < OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
patching file build.gradle
Hunk #1 succeeded at 285 (offset 7 lines).
Hunk #2 FAILED at 1032.
1 out of 2 hunks FAILED -- saving rejects to file build.gradle.rej

Maybe you have pending changes in your build.gradle file?

> Simplify ‘getJarManifestClasspathForCurrentOs’ method
> -----------------------------------------------------
>
>                 Key: OFBIZ-10872
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10872
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Trivial
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
>
>
> pure refactoring for providing a more concise implementation of {{getJarManifestClasspathForCurrentOs}} which has been renamed {{getJarClasspath}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)